linux-kernel - Re: [PATCH 1/1] Char: nozomi, fix tty->count counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C514650.8010305@gmail.com>
Date:	Thu, 29 Jul 2010 11:13:52 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	Alan Cox s <alan@...ux.intel.com>, stable@...nel.org
Subject: Re: [PATCH 1/1] Char: nozomi, fix tty->count counting

On 07/29/2010 11:09 AM, Jiri Slaby wrote:
> Currently ntty_install omits to increment tty count and we get the
> following warnings:
> Warning: dev (noz2) tty->count(0) != #fd's(1) in tty_open
> 
> So to fix that, add one tty->count++ there.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Alan Cox <alan@...ux.intel.com>

BTW introduced in 266794eb7 (nozomi: Add tty_port usage) which is in
.34. So may be a stable material too...

> ---
>  drivers/char/nozomi.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/char/nozomi.c b/drivers/char/nozomi.c
> index d578449..7f9b858 100644
> --- a/drivers/char/nozomi.c
> +++ b/drivers/char/nozomi.c
> @@ -1611,6 +1611,7 @@ static int ntty_install(struct tty_driver *driver, struct tty_struct *tty)
>  	ret = tty_init_termios(tty);
>  	if (ret == 0) {
>  		tty_driver_kref_get(driver);
> +		tty->count++;
>  		driver->ttys[tty->index] = tty;
>  	}
>  	return ret;

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/