lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Jul 2010 17:13:00 +0100 From: Alan Cox <alan@...rguk.ukuu.org.uk> To: Kulikov Vasiliy <segooon@...il.com> Cc: kernel-janitors@...r.kernel.org, "Michael H. Warfield" <mhw@...tsend.com>, Greg Kroah-Hartman <gregkh@...e.de>, Rakib Mullick <rakib.mullick@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] char: ip2: check put_user() result O> - return dumpcount; > + return rc ? -EFAULT : dumpcount; This is actually at least as wrong as before. The standards say that if you successfully return some data you should report the bytes returned. Normally it doesn't matter much because the data has not been 'lost' when it gets called again. If you actually remove the data from the queue it ought to be getting reported with a suitable length. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists