linux-kernel - Re: [PATCH rfc] firewire: add isochronous multichannel reception

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C51A88B.3040807@s5r6.in-berlin.de>
Date:	Thu, 29 Jul 2010 18:12:59 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux1394-devel@...ts.sourceforge.net
CC:	linux-kernel@...r.kernel.org, Jay Fenlason <fenlason@...hat.com>
Subject: Re: [PATCH rfc] firewire: add isochronous multichannel reception

Stefan Richter wrote:
>  static int ohci_queue_iso(struct fw_iso_context *base,
>  			  struct fw_iso_packet *packet,
>  			  struct fw_iso_buffer *buffer,
> @@ -2587,14 +2761,17 @@ static int ohci_queue_iso(struct fw_iso_
>  {
>  	struct iso_context *ctx = container_of(base, struct iso_context, base);
>  	unsigned long flags;
> -	int ret;
> +	int ret = -ENOSYS;
>  
>  	spin_lock_irqsave(&ctx->context.ohci->lock, flags);
> -	if (base->type == FW_ISO_CONTEXT_TRANSMIT)
> -		ret = ohci_queue_iso_transmit(base, packet, buffer, payload);
> -	else
> -		ret = ohci_queue_iso_receive_packet_per_buffer(base, packet,
> -							buffer, payload);
> +	switch (base->type) {
> +	case FW_ISO_CONTEXT_TRANSMIT:
> +		ret = queue_iso_transmit(base, packet, buffer, payload);
> +	case FW_ISO_CONTEXT_RECEIVE:
> +		ret = queue_iso_packet_per_buffer(base, packet, buffer, payload);
> +	case FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL:
> +		ret = queue_iso_buffer_fill(base, packet, buffer, payload);
> +	}
>  	spin_unlock_irqrestore(&ctx->context.ohci->lock, flags);
>  
>  	return ret;

Where is the brown paper bag...
There should be break; at each case.  Updated patch is at
http://user.in-berlin.de/~s5r6/linux1394/pending/1171-firewire-add-isochronous-multichannel-reception.patch
-- 
Stefan Richter
-=====-==-=- -=== ===-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/