linux-kernel - Re: [PATCH -next] scsi: be2iscsi needs ISCSI_BOOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100729193420.GB13308@andromeda.dapyr.net>
Date:	Thu, 29 Jul 2010 15:34:20 -0400
From:	Konrad Rzeszutek Wilk <konrad@...nel.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	scsi <linux-scsi@...r.kernel.org>,
	Jayamohan Kallickal <jayamohank@...verengines.com>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	jejbscsi <james.bottomley@...e.de>
Subject: Re: [PATCH -next] scsi: be2iscsi needs ISCSI_BOOT_SYSFS

On Thu, Jul 29, 2010 at 10:16:09AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> be2iscsi uses iscsi_boot_*() interfaces, so it should ensure that
> ISCSI_BOOT_SYSFS is enabled.
> 
> ERROR: "iscsi_boot_create_target" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
> ERROR: "iscsi_boot_create_ethernet" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
> ERROR: "iscsi_boot_create_host_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
> ERROR: "iscsi_boot_create_initiator" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
> ERROR: "iscsi_boot_destroy_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Acked-by: Konrad Rzeszutek Wilk <konrad@...nel.org>

> ---
>  drivers/scsi/be2iscsi/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20100729.orig/drivers/scsi/be2iscsi/Kconfig
> +++ linux-next-20100729/drivers/scsi/be2iscsi/Kconfig
> @@ -2,6 +2,7 @@ config BE2ISCSI
>  	tristate "ServerEngines' 10Gbps iSCSI - BladeEngine 2"
>  	depends on PCI && SCSI && NET
>  	select SCSI_ISCSI_ATTRS
> +	select ISCSI_BOOT_SYSFS
>  
>  	help
>  	This driver implements the iSCSI functionality for ServerEngines'
> ---
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/