linux-kernel - Re: [PATCH 0/6] Remove owner field from sysfs attribute structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1280485690.1902.8.camel@pasglop>
Date:	Fri, 30 Jul 2010 20:28:10 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Tejun Heo <tj@...nel.org>
Cc:	Guenter Roeck <guenter.roeck@...csson.com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	Richard Purdie <rpurdie@...ys.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Paul Mackerras <paulus@...ba.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Dmitry Torokhov <dtor@...l.ru>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Jani Nikula <ext-jani.1.nikula@...ia.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Chris Wright <chrisw@...s-sol.org>,
	Nick Cheng <nick.cheng@...ca.com.tw>,
	James Smart <james.smart@...lex.com>,
	Alex Iannicelli <alex.iannicelli@...lex.com>,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>,
	Benjamin Thery <benjamin.thery@...l.net>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH 0/6] Remove owner field from sysfs attribute structure

On Fri, 2010-07-30 at 10:45 +0200, Tejun Heo wrote:
> On 07/29/2010 07:09 AM, Guenter Roeck wrote:
> > The following comment is found in include/linux/sysfs.h:
> > 
> >    /* FIXME
> >     * The *owner field is no longer used.
> >     * x86 tree has been cleaned up. The owner
> >     * attribute is still left for other arches.
> >     */
> > 
> > As it turns out, the *owner field is (again?) initialized in several modules,
> > suggesting that such initialization may be creeping back into the code.
> > 
> > This patch set removes the above comment, the *owner field, and each instance
> > in the code where it was found to be initialized.
> > 
> > Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc,
> > and sparc defconfig builds.
> 
> Yeah, the change is way overdue.  Maybe we should have just removed
> them back then.

I'm happy with the powerpc related patches as long as we all agree that
needs to go. Do you need me to put some of this in powerpc.git or are
you carrying them all to Linus ?

Cheers,
Ben.

>  Acked-by: Tejun Heo <tj@...nel.org>
> 
> Thanks.
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/