linux-kernel - Re: [PATCH 2/9] staging: octeon: check request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C52ED82.6040703@caviumnetworks.com>
Date:	Fri, 30 Jul 2010 08:19:30 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Kulikov Vasiliy <segooon@...il.com>
CC:	kernel-janitors@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Ralf Baechle <ralf@...ux-mips.org>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] staging: octeon: check request_irq() return value

On 07/30/2010 04:07 AM, Kulikov Vasiliy wrote:
> request_irq() may fail, if so propagate error code.
>
> Signed-off-by: Kulikov Vasiliy<segooon@...il.com>

You can add:

Acked-by: David Daney <ddaney@...iumnetworks.com>


> ---
>   drivers/staging/octeon/ethernet-spi.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-spi.c b/drivers/staging/octeon/ethernet-spi.c
> index b58b897..9708254 100644
> --- a/drivers/staging/octeon/ethernet-spi.c
> +++ b/drivers/staging/octeon/ethernet-spi.c
> @@ -294,6 +294,8 @@ int cvm_oct_spi_init(struct net_device *dev)
>   	if (number_spi_ports == 0) {
>   		r = request_irq(OCTEON_IRQ_RML, cvm_oct_spi_rml_interrupt,
>   				IRQF_SHARED, "SPI",&number_spi_ports);
> +		if (r)
> +			return r;
>   	}
>   	number_spi_ports++;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/