linux-kernel - Re: Memory corruption during hibernation since 2.6.31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=HFg9zcAoUZbYzT2j7X11oDZs=xgrJynT=3GM6@mail.gmail.com>
Date:	Thu, 29 Jul 2010 21:32:35 -0700
From:	Hugh Dickins <hughd@...gle.com>
To:	balbir@...ux.vnet.ibm.com
Cc:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Ondrej Zary <linux@...nbow-software.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: Memory corruption during hibernation since 2.6.31

On Thu, Jul 29, 2010 at 9:18 PM, Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
>
> Couldn't we reuse PF_* flags to differentiate between the paths, if
> that is what it eventually boils down to? On an unrelated note, I was
> looking at shrink_all_memory() and wondering if swappiness really
> mattered there.

So far as the swap-reuse issue goes, I don't see that a PF_ flag
would help: the threads that already worry about such issues do
the set_freezable()/try_to_freeze() thing, and won't get into
trouble anyway; we don't want to force every other thread to
have to do something special now, better just check global state
in the very few places its needed.

On the unrelated note: better in an unrelated thread!

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/