linux-kernel - Re: [PATCH] musb: move usb_add_hcd to the core init code from gadget code (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C525AAF.6020102@canonical.com>
Date:	Fri, 30 Jul 2010 12:53:03 +0800
From:	Bryan Wu <bryan.wu@...onical.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>, felipe.balbi@...ia.com
CC:	linux-usb@...r.kernel.org, kernel-team@...ts.ubuntu.com,
	linux-kernel@...r.kernel.org, ricardo.salveti@...onical.com,
	david-b@...bell.net
Subject: Re: [PATCH] musb: move usb_add_hcd to the core init code from gadget
 code (v2)

On 07/23/2010 11:28 PM, Sergei Shtylyov wrote:
> Hello.
> 
> Bryan Wu wrote:
> 
>> BugLink: http://bugs.launchpad.net/bugs/608312
> 
>> v2:
>> fix the building error on latest 2.6.35-rc kernel, since v1 was
>> generated in
>> 2.6.33 kernel.
> 
>    The remarks about patch changes should follow the --- tear line.
> 

Thanks Sergei, I will take care of it in the future.

Any other comments about this patch?

Felipe, could you please take a look? or need I ping you in the Facebook, -:))

-Bryan

>> v1:
>> usb_add_hcd was only called when we insmod the gadget class module or
>> built-in
>> that gadget class driver. If musb is configured as OTG controller, we
>> need to
>> insmod or built-in gadget class driver to make our Host mode fucntion
>> works.
> 
>> In our Ubuntu system, normally we compiled all the gadget class
>> drivers as
>> modules. Then users can insmod the gadget modules as they want. But
>> without the
>> gadget class driver running, we needs host function to support common USB
>> devices.
> 
>> This patch fix this issue and tested on omap3 beagle board and Gumstix
>> board.
> 
>> Signed-off-by: Bryan Wu <bryan.wu@...onical.com>
> 
> WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/