linux-kernel - Re: [PATCH] loop: add some basic read-only sysfs attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=anz24S=TpBGZRvrEoTKm21kWFRypD+R96T4Oz@mail.gmail.com>
Date:	Fri, 30 Jul 2010 10:01:28 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	Karel Zak <kzak@...hat.com>
Cc:	Milan Broz <mbroz@...hat.com>, util-linux-ng@...r.kernel.org,
	linux-kernel@...r.kernel.org, axboe@...nel.dk
Subject: Re: [PATCH] loop: add some basic read-only sysfs attributes

On Fri, Jul 30, 2010 at 09:43, Kay Sievers <kay.sievers@...y.org> wrote:
> On Fri, Jul 30, 2010 at 09:37, Karel Zak <kzak@...hat.com> wrote:
>> On Thu, Jul 29, 2010 at 06:07:31PM +0200, Kay Sievers wrote:
>>> Sure it does. Sysfs attributes need to be created _before_ uevents are
>>> sent out. The current behavior is that all blockdev attributes are
>>> safely created before the event is sent.
>>
>>  Hmm... I see that in add_disk(), the "queue" subdirectory is created
>>  after disk registration (the register_disk() calls kobject_uevent()).
>>  Is it true?
>
> Might be. Then seems nobody has tried using this stuff from udev. :)
>
> blk_register_queue() probably needs to move to register_disk(), where
> the uevent is delayed until all stuff is properly created.

Seems, someone should finally move register_disk() from
fs/partition/check.c to block/genhd.c, where it belongs, and merge the
code into add_disk(), where the control over the event timing is
easily possible.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/