linux-kernel - Re: [PATCH]acpi:glue.c Fix warning: variable 'ret' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C54707B.4040008@gmail.com>
Date:	Sat, 31 Jul 2010 11:50:35 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	"Justin P. Mattock" <justinmattock@...il.com>
CC:	linux-acpi@...r.kernel.org, lenb@...nel.org, dhowells@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]acpi:glue.c Fix warning: variable 'ret' set but not used

whats going on with this patch? havent heard anything on this.

> Fix a warning message generated by gcc:
>    CC      drivers/acpi/glue.o
> drivers/acpi/glue.c: In function 'acpi_bind_one':
> drivers/acpi/glue.c:163:7: warning: variable 'ret' set but not used
>
> Signed-off-by: Justin P. Mattock<justinmattock@...il.com>
> Signed-off-by: David Howells<dhowells@...hat.com>
>
> ---
>   drivers/acpi/glue.c |   14 +++++++++++---
>   1 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> index 4af6301..23b16e6 100644
> --- a/drivers/acpi/glue.c
> +++ b/drivers/acpi/glue.c
> @@ -145,6 +145,7 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle)
>   {
>   	struct acpi_device *acpi_dev;
>   	acpi_status status;
> +	int fn, pn;
>
>   	if (dev->archdata.acpi_handle) {
>   		dev_warn(dev, "Drivers changed 'acpi_handle'\n");
> @@ -160,12 +161,19 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle)
>
>   	status = acpi_bus_get_device(handle,&acpi_dev);
>   	if (!ACPI_FAILURE(status)) {
> -		int ret;
>
> -		ret = sysfs_create_link(&dev->kobj,&acpi_dev->dev.kobj,
> +		fn = sysfs_create_link(&dev->kobj,&acpi_dev->dev.kobj,
>   				"firmware_node");
> -		ret = sysfs_create_link(&acpi_dev->dev.kobj,&dev->kobj,
> +		pn = sysfs_create_link(&acpi_dev->dev.kobj,&dev->kobj,
>   				"physical_node");
> +		if (fn || pn) {
> +			dev_warn(&acpi_dev->dev,
> +				"Failed to create link(s) to %s %s:"
> +				" %d\n",
> +				dev_driver_string(dev), dev_name(dev),
> +				fn ?: pn);
> +				return AE_ERROR;
> +		}
>   		if (acpi_dev->wakeup.flags.valid) {
>   			device_set_wakeup_capable(dev, true);
>   			device_set_wakeup_enable(dev,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/