linux-kernel - Re: [PATCH]irq:manage.c Fix warning: variable 'old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C5473AB.709@gmail.com>
Date:	Sat, 31 Jul 2010 12:04:11 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	"Justin P. Mattock" <justinmattock@...il.com>
CC:	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	peterz@...radead.org
Subject: Re: [PATCH]irq:manage.c Fix warning: variable 'old_name' set but
 not used

haven't heard anything on this.. is this in the vicinity of being a 
right solution?

> Not sure if this is the right approach with this.. The below
> fixes a warning message generated by GCC
>    CC      kernel/irq/manage.o
> kernel/irq/manage.c: In function '__setup_irq':
> kernel/irq/manage.c:652:14: warning: variable 'old_name' set but not used
>
> Signed-off-by: Justin P. Mattock<justinmattock@...il.com>
>
> ---
>   kernel/irq/manage.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index e149748..99d2f39 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -733,6 +733,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
>   		if (!((old->flags&  new->flags)&  IRQF_SHARED) ||
>   		    ((old->flags ^ new->flags)&  IRQF_TRIGGER_MASK)) {
>   			old_name = old->name;
> +			if(old_name) {
> +				printk(KERN_ERR "IRQ mismatch: %d %s\n", IRQF_SHARED, old_name);
> +			}	
>   			goto mismatch;
>   		}
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/