linux-kernel - Re: [PATCH] p54spi: replace internal "cx3110x" name with "p54spi"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87iq3wdmbg.fsf@purkki.adurom.net>
Date:	Sat, 31 Jul 2010 12:37:07 +0300
From:	Kalle Valo <kvalo@...rom.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Luke-Jr <luke@...hjr.org>, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH] p54spi: replace internal "cx3110x" name with "p54spi"

Johannes Berg <johannes@...solutions.net> writes:

> On Wed, 2010-06-02 at 14:06 -0500, Luke-Jr wrote:
>
>> > >  	.driver = {
>> > > -		/* use cx3110x name because board-n800.c uses that for the
>> > > -		 * SPI port */
>> > > -		.name		= "cx3110x",
>> > > +		.name		= "p54spi",
>> > >  		.bus		= &spi_bus_type,
>> > 
>> > maybe that comment wasn't clear enough ... it needs to be that way to be
>> > properly linked up against SPI.
>> 
>> I don't understand what you mean here. Does the hardware-side of SPI use 
>> string identifiers? These are the only two instances of "cx3110x" in the 
>> kernel source; N8x0 board files expect "p54spi"
>
> Hm, ok, I thought that the board stuff needed cx3110x. Hopefully it
> doesn't differ in n810s?

I changed the n8x0 board files (for both n800 and n810) in mainline to
use p54spi. So this patch is correct.

The old maemo kernels and the closed driver used cx3110x to identify
the spi device.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/