linux-kernel - Re: [PATCH] nconfig: add search support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100801092859.GA12213@merkur.ravnborg.org>
Date:	Sun, 1 Aug 2010 11:28:59 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	nir.tzachar@...il.com
Cc:	mmarek@...e.cz, rdunlap@...otime.net, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, trapdoor6@...il.com,
	justinmattock@...il.com
Subject: Re: [PATCH] nconfig: add search support

On Sun, Aug 01, 2010 at 10:20:33AM +0300, nir.tzachar@...il.com wrote:
> From: Nir Tzachar <nir.tzachar@...il.com>
> 
> Remove the old hotkeys feature, and replace by a regular string search.
> >From nconfig help:
> 
> Pressing '/' triggers search mode. nconfig does regular string match, case
> insensitive, starting at the begining of each menu line.
> Pressing Enter highlights the next match, Backspace removes one character from
> the match string. Pressing either '/' again or ESC exits search mode.
> 
> Rebind the '/' key (which allowed to search for symbols) to F8
> 
> Signed-off-by: Nir Tzachar <nir.tzachar@...il.com>

Got following warning when I build:
scripts/kconfig/nconf.c: In function Ã¢t_mext_matchÃ¢scripts/kconfig/nconf.c:512: warning: implicit declaration of function Ã¢blankÃ¢

The searching works great! And good to see the capitilazation gone.

But it is ackward that I have to press ESC to leave searcing.

I can navigate up/down, but entering a menu should terminate search.
Also pressing enter (to select a symbol) should terminate search.

I also tried to do first search using "/", then search for a symbol using F8.
Again search was not terminated when I came back.

There is likely much more cases...

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/