linux-kernel - Re: [PATCH] watchdog: Add watchdog driver for OCTEON SOCs (v2).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100802123755.GV30740@infomag.iguana.be>
Date:	Mon, 2 Aug 2010 14:37:55 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	David Daney <ddaney@...iumnetworks.com>, ralf@...ux-mips.org
Cc:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>,
	Marc Zyngier <maz@...terjones.org>,
	Thierry Reding <thierry.reding@...onic-design.de>,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH] watchdog: Add watchdog driver for OCTEON SOCs (v2).

Hi David, Ralf,

> The OCTEON is a MIPS64 based SOC family with an on chip watchdog unit.
> 
> The driver is split into two source files one for the C code and one
> for assembly.  Assembly is needed to handle the NMI and then print the
> machine state before the reboot is triggered.
> 
> v2: Stylistic changes suggested by Sam Ravnborg.

This v2 looks good. only small remark is:
> +static struct notifier_block octeon_wdt_cpu_notifier = {
> +	.notifier_call = octeon_wdt_cpu_callback
> +};

Add a comma after octeon_wdt_cpu_callback.

> Signed-off-by: David Daney <ddaney@...iumnetworks.com>
> Cc: Wim Van Sebroeck <wim@...ana.be>

Signed-off-by: Wim Van Sebroeck <wim@...ana.be>

> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Russell King <rmk+kernel@....linux.org.uk>
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Marc Zyngier <maz@...terjones.org>
> Cc: Thierry Reding <thierry.reding@...onic-design.de>
> Cc: Sam Ravnborg <sam@...nborg.org>

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/