linux-kernel - Re: 6175ddf06b6172046a329e3abfd9c901a43efd2e breaks matroxfb console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C5732DC.8010800@zytor.com>
Date:	Mon, 02 Aug 2010 14:04:28 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ondrej Zary <linux@...nbow-software.org>
CC:	brgerst@...il.com,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: 6175ddf06b6172046a329e3abfd9c901a43efd2e breaks matroxfb console

On 08/02/2010 12:49 PM, Ondrej Zary wrote:
> Hello,
> matroxfb (at least with Mystique and Mystique 220) stopped working in 2.6.34 - 
> the screen is completely corrupted. Bisection shows that 
> 6175ddf06b6172046a329e3abfd9c901a43efd2e is first bad commit.
> 
> Reverting 6175ddf06b6172046a329e3abfd9c901a43efd2e in 2.6.34 fixes the problem 
> (1c5b9069e12e20d2fe883076ae0bf73966492108 must be reverted first).
> 

Sounds like another driver which used memcpy_toio() when it should have
used iowrite32_rep() or __iowrite32_copy().

Hmm... is __iowrite32_copy() and iowrite32_rep() redundant?  If so, we
should get rid of the former.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/