linux-kernel - Re: [PATCH v2 3/3] rtc: Add MAX8998 rtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100803020847.58795fbd@linux.lan.towertech.it>
Date:	Tue, 3 Aug 2010 02:08:47 +0200
From:	Alessandro Zummo <a.zummo@...ertech.it>
To:	Joonyoung Shim <jy0922.shim@...sung.com>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com,
	broonie@...nsource.wolfsonmicro.com, lrg@...mlogic.co.uk,
	akpm@...ux-foundation.org, p_gortmaker@...oo.com,
	kyungmin.park@...sung.com, m.szyprowski@...sung.com
Subject: Re: [PATCH v2 3/3] rtc: Add MAX8998 rtc driver

On Mon, 02 Aug 2010 16:35:07 +0900
Joonyoung Shim <jy0922.shim@...sung.com> wrote:

> This adds support for the RTC provided by the Maxim 8998 chip. This
> driver was tested on a GONI board by using the rtc-test application from
> the Documentation/rtc.txt.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> Acked-by: Samuel Ortiz <sameo@...ux.intel.com>

 Seems nice. I'd add rtc_valid_tm where appropriate.
 And maybe free that irq you requested ;)

 pending those changes, you have my 

  Acked-by: Alessandro Zummo <a.zummo@...ertech.it>


-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/