linux-kernel - Re: [PATCH] usb gadget: don't save bind callback in struct usb_gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100803074056.GB17297@pengutronix.de>
Date:	Tue, 3 Aug 2010 09:40:57 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Greg KH <gregkh@...e.de>
Cc:	Julia Lawall <julia@...u.dk>,
	Michał Nazarewicz <m.nazarewicz@...sung.com>,
	linux-usb@...r.kernel.org, David Brownell <david-b@...bell.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb gadget: don't save bind callback in struct
	usb_gadget_driver

[stripped down Cc: list to annoy fewer people]

On Mon, Aug 02, 2010 at 03:54:40PM -0700, Greg KH wrote:
> On Mon, Aug 02, 2010 at 03:12:48PM +0200, Uwe Kleine-König wrote:
> > On Mon, Aug 02, 2010 at 02:51:36PM +0200, Julia Lawall wrote:
> > > > diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> > > > index 731150d..c266c1e 100644
> > > > --- a/drivers/usb/gadget/amd5536udc.c
> > > > +++ b/drivers/usb/gadget/amd5536udc.c
> > > > @@ -1954,13 +1954,14 @@ static int setup_ep0(struct udc *dev)
> > > >  }
> > > >  
> > > >  /* Called by gadget driver to register itself */
> > > > -int usb_gadget_register_driver(struct usb_gadget_driver *driver)
> > > > +int usb_gadget_probe_driver(struct usb_gadget_driver *driver,
> > > > +		int (*bind)(struct usb_gadget *))
> > > >  {
> > > >  	struct udc		*dev = udc;
> > > >  	int			retval;
> > > >  	u32 tmp;
> > > >  
> > > > -	if (!driver || !driver->bind || !driver->setup
> > > > +	if (!driver || bind || !driver->setup
> > > 
> > > I have the impression that this should be !bind rather than bind.  
> > ah, now I see what you meant.  Obviously you're right.  I fixed it up
> > locally here for now.  Greg, just tell me when/if you need a fixed
> > patch.
> 
> Didn't you already post a "fixed" patch?
Yes, I did:

	http://article.gmane.org/gmane.linux.ports.arm.kernel/86640
	http://article.gmane.org/gmane.linux.kernel/1017575

If you append '/raw' to the URL they should be applicable by
git/quilt/whatever you use.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/