linux-kernel - Re: [PATCH] Staging: dt3155: properly export the module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100803010559.GA3814@kroah.com>
Date:	Mon, 2 Aug 2010 18:05:59 -0700
From:	Greg KH <greg@...ah.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Jiri Slaby <jirislaby@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"ss@....gov.au" <ss@....gov.au>, "gregkh@...e.de" <gregkh@...e.de>
Subject: Re: [PATCH] Staging: dt3155: properly export the module parameter

On Thu, Jul 29, 2010 at 11:02:38AM -0500, H Hartley Sweeten wrote:
> On Thursday, July 29, 2010 6:09 AM, Jiri Slaby wrote:
> > On 07/29/2010 02:55 AM, H Hartley Sweeten wrote:
> >> On Wednesday, July 28, 2010 1:59 PM, Jiri Slaby wrote:
> >>> On 07/28/2010 06:48 PM, H Hartley Sweeten wrote:
> >>>> --- a/drivers/staging/dt3155/dt3155_drv.c
> >>>> +++ b/drivers/staging/dt3155/dt3155_drv.c
> >>>> @@ -99,7 +99,9 @@ wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS];
> >>>>  
> >>>>  /* set to dynamicaly allocate, but it is tunable: */
> >>>>  /* insmod DT_3155 dt3155 dt3155_major=XX */
> >>>> -int dt3155_major = 0;
> >>>> +static int dt3155_major;
> >>>> +module_param(dt3155_major, int, 0);
> >>>> +MODULE_PARM_DESC(dt3155_major, "Major device number");
> >>>
> >>> Is it necessary in the age of udev?
> >>>
> >>> I would personally get rid of that completely...
> >> 
> >> I agree but I'm not quite sure if the user space app is ready to handle that.
> >
> > Given it was never exposed as a parameter, applications should handle
> > that. 0 means allocate major dynamically...
> 
> Understood.
> 
> I finally found the "official" site for the "DT3155 Framegrabber Linux Device Driver"
> 
> http://sourceforge.net/projects/dt3155a/
> 
> The script provided to load the module does grep /proc/devices to determine the major
> device number and then mknod's the appropriate devices.
> 
> I will update my patch and remove the "parameter" since it is not needed.

As there is another driver already in the tree for this device,
dt3155v4l, I'm about to delete the dt3155 driver as it's no longer
needed.  So you might want to reconsider your work on this driver for
the near future.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/