linux-kernel - Re: [PATCHv6 00/15] kill unnecessary bdi wakeups + cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C580FFF.2000605@kernel.dk>
Date:	Tue, 03 Aug 2010 14:47:59 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	dedekind1@...il.com
CC:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCHv6 00/15] kill unnecessary bdi wakeups + cleanups

On 2010-08-03 14:37, Artem Bityutskiy wrote:
> On Tue, 2010-08-03 at 14:27 +0200, Jens Axboe wrote:
>> On 2010-07-25 13:29, Artem Bityutskiy wrote:
>>> Hi,
>>>
>>> here is v6 of the patch series which clean-ups bdi threads and substantially
>>> lessens amount of unnecessary kernel wake-ups, which is very important on
>>> battery-powered devices.
>>>
>>> This patch-set is also available at:
>>> git://git.infradead.org/users/dedekind/misc-2.6.git flushers_v6
>>
>> Thanks Artem, for sticking around long enough to get this into
>> shape. I have finally merged it.
> 
> Thanks, but
> 
>>> 1. Use 'spin_lock_bh' for the 'bdi->wb_lock' (changed patch N12)
>>
>> I'd rather not, question is how to avoid it. Either just wakeup the
>> default thread, or punt the lock-and-check bdi->wb.task to a thread.
> 
> you merged this change, do you want me to send a separate patch which
> undo the 'spin_lock_bh' change? I'll think about how to avoid this and
> come back.

Yes, it's not a huge thing, but it would be nice to get rid of. So I
figured it was better to merge it and not have you respin the series yet
again.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/