linux-kernel - Re: [PATCH] Staging: wlan-ng: remove typedef in p80211ioctl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201008031524.04730.arnd@arndb.de>
Date:	Tue, 3 Aug 2010 15:24:04 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Edgardo Hames <ehames@...il.com>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: remove typedef in p80211ioctl.h

On Saturday 31 July 2010, Edgardo Hames wrote:
> 
> -typedef struct p80211ioctl_req {
> +struct p80211ioctl_req {
>         char name[WLAN_DEVNAMELEN_MAX];
>         caddr_t data;
>         u32 magic;
>         u16 len;
>         u32 result;
> -} __attribute__ ((packed)) p80211ioctl_req_t;
> +} __attribute__ ((packed));

BTW, this data structure is broken and needs fixing.
Putting a pointer in there means that it's incompatible
between 32 and 64 bit user space, among other problems.

The TODO list for this driver already contains "move to
use the in-kernel wireless stack", which should consequently
imply getting rid of this p80211knetdev_do_ioctl function, but
it may be useful to list that as a separate item.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/