linux-kernel - Re: [PATCH] tc6393xb: fix wrong goto labels for error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTik5Tvr_7v1gB55h3kwxB8yihwhnSMVT-=T=a44_@mail.gmail.com>
Date:	Tue, 3 Aug 2010 14:45:40 +0100
From:	Ian Molton <ian@...menth.co.uk>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] tc6393xb: fix wrong goto labels for error handling

Acked-by: Ian Molton <ian.molton@...menth.co.uk>

On 3 August 2010 04:10, Axel Lin <axel.lin@...il.com> wrote:
> This patch corrects the error handling path.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mfd/tc6393xb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index fcf9068..ef6c42c 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -732,9 +732,9 @@ err_gpio_add:
>        if (tc6393xb->gpio.base != -1)
>                temp = gpiochip_remove(&tc6393xb->gpio);
>        tcpd->disable(dev);
> -err_clk_enable:
> -       clk_disable(tc6393xb->clk);
>  err_enable:
> +       clk_disable(tc6393xb->clk);
> +err_clk_enable:
>        iounmap(tc6393xb->scr);
>  err_ioremap:
>        release_resource(&tc6393xb->rscr);
> --
> 1.5.4.3
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/