linux-kernel - [PATCH] phy: Add missing forward declaration (fixes compiler warning)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue,  3 Aug 2010 19:04:01 +0200
From:	Stefan Weil <weil@...l.berlios.de>
To:	linux-kernel@...r.kernel.org
Cc:	Stefan Weil <weil@...l.berlios.de>,
	"David S. Miller" <davem@...emloft.net>,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Ben Hutchings <ben@...adent.org.uk>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Subject: [PATCH] phy: Add missing forward declaration (fixes compiler warning)

Without forward declaration for struct sk_buff, compilation
of drivers/net/phy/fixed.c results in a warning:

  CC      drivers/net/phy/fixed.o
In file included from drivers/net/phy/fixed.c:20:
include/linux/phy.h:342: warning: 'struct sk_buff' declared inside parameter list
include/linux/phy.h:342: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/phy.h:343: warning: 'struct sk_buff' declared inside parameter list

(tested with linux kernel for openwrt / ar7, gcc-4.1.2)

Cc: David S. Miller <davem@...emloft.net>
Cc: Anton Vorontsov <avorontsov@...mvista.com>
Cc: Ben Hutchings <ben@...adent.org.uk>
Cc: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc: linux-kernel@...r.kernel.org
Signed-off-by: Stefan Weil <weil@...l.berlios.de>
---
 include/linux/phy.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/phy.h b/include/linux/phy.h
index 987e111..65e8d72 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -51,6 +51,8 @@
 #define PHY_HAS_INTERRUPT	0x00000001
 #define PHY_HAS_MAGICANEG	0x00000002
 
+struct sk_buff;
+
 /* Interface Mode definitions */
 typedef enum {
 	PHY_INTERFACE_MODE_MII,
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/