linux-kernel - RE: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Aug 2010 12:33:51 -0500
From:	"Ramos Falcon, Ernesto" <ernesto@...com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"Ramirez Luna, Omar" <omar.ramirez@...com>,
	"ohad@...ery.com" <ohad@...ery.com>,
	"ameya.palande@...ia.com" <ameya.palande@...ia.com>,
	"felipe.contreras@...ia.com" <felipe.contreras@...ia.com>,
	"Guzman Lugo, Fernando" <fernando.lugo@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Menon, Nishanth" <nm@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: RE: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by
 	strict_strtoul

Hi,

>-----Original Message-----
>From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
>Sent: Wednesday, July 28, 2010 1:44 PM
>To: Ramos Falcon, Ernesto
>Cc: gregkh@...e.de; Ramirez Luna, Omar; ohad@...ery.com;
>ameya.palande@...ia.com; felipe.contreras@...ia.com; Guzman Lugo, Fernando;
>linux-kernel@...r.kernel.org; Menon, Nishanth; linux-omap@...r.kernel.org
>Subject: Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by
>strict_strtoul
>
>On Wed, Jul 28, 2010 at 5:40 PM, Ernesto Ramos <ernesto@...com> wrote:
>> Replace simple_strtoul by strict_strtoul in atoi function.
>In general the question what is the purpose here to do the change?
>

It is recommended to use strict_strtoul instead of simple_strtoul since ensures the string is really a valid unsigned long. This also removes checkpatch warning message.

>> @@ -1023,7 +1025,9 @@ static s32 atoi(char *psz_buf)
>>                base = 16;
>>        }
>>
>> -       return simple_strtoul(pch, NULL, base);
>> +       ret_val = strict_strtoul(pch, base, &res);
>> +
>> +       return ret_val ? : res;
>May be better to use explicit values in condition?
>

I think this is ok as it is, I'm not sure but I think it maybe defined in any C ansi book, in this case if ret_val is unequal to 0 ret_val is returned.

>--
>With Best Regards,
>Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/