linux-kernel - Re: [PATCH 4/6] staging: hv: Removed TODO for VMBUS, it mirrors HYPER-V behavior to closely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Aug 2010 10:42:43 -0700
From:	Greg KH <gregkh@...e.de>
To:	Hank Janssen <hjanssen@...rosoft.com>
Cc:	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"'devel@...verdev.osuosl.org'" <devel@...verdev.osuosl.org>,
	"'virtualization@...ts.osdl.org'" <virtualization@...ts.osdl.org>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH 4/6] staging: hv: Removed TODO for VMBUS, it mirrors
 HYPER-V behavior to closely

On Tue, Aug 03, 2010 at 05:31:54PM +0000, Hank Janssen wrote:
> From: Hank Janssen <hjanssen@...rosoft.com>
> 
> Removed TODO for VMBUS, it mirrors HYPER-V behaviour to closely and does not really share any 
> usable functionality of the Linux kernel facilities. There is not really an easy way to combine functionality.

Are you sure about that?  Right now, the code doesn't look like any
other virtual bus code, but that's because it needs to be fixed up and
work properly (not with the two layers of indirection that was added a
long time ago before the code was opened up.)

I think once the code is cleaned up properly, you might find that it can
be combined much easier than you think...

So no, I'll not allow this TODO item to be removed until after the vbus
code is fixed up, and you can convince me that it really is unique
enough to remain as-is.

Oh, and again, please properly line-wrap your changelog comments.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/