linux-kernel - Re: [PATCH] staging/rt2860: fix bad dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100804141100U.fujita.tomonori@lab.ntt.co.jp>
Date:	Wed, 4 Aug 2010 14:11:46 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	martinez.javier@...il.com
Cc:	gregkh@...e.de, bzolnier@...il.com, ben@...adent.org.uk,
	revent82@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] staging/rt2860: fix bad dma_addr_t conversion

On Wed, 04 Aug 2010 00:45:19 -0400
Javier Martinez Canillas <martinez.javier@...il.com> wrote:

> DMA addresses are not pointers and shouldn't be assigned to NULL.
> This patch was generated against today linux-next.
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@...il.com>
> ---
>  drivers/staging/rt2860/rt_pci_rbus.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/rt2860/rt_pci_rbus.c b/drivers/staging/rt2860/rt_pci_rbus.c
> index 3004be6..244c754 100644
> --- a/drivers/staging/rt2860/rt_pci_rbus.c
> +++ b/drivers/staging/rt2860/rt_pci_rbus.c
> @@ -218,7 +218,7 @@ void *RTMP_AllocateRxPacketBuffer(struct rt_rtmp_adapter *pAd,
>  				   PCI_DMA_FROMDEVICE);
>  	} else {
>  		*VirtualAddress = (void *)NULL;
> -		*PhysicalAddress = (dma_addr_t)NULL;
> +		*PhysicalAddress = 0;
>  	}

This doesn't look correct since zero is a valid DMA address on some
architectures.

I recommend removing the else part completely. If you need to mark a
rx buffer invalid, adding a flag to the rx descriptor structure of a
driver is a popular way (see other network drivers, e.g. bnx2).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/