linux-kernel - Re: [PATCH] max8998: fix off-by-one value range checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Aug 2010 15:39:21 +0900
From:	Kyungmin Park <kmpark@...radead.org>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH] max8998: fix off-by-one value range checking

Nice catch.

Acked-by: Kyungmin Park <kyungmin.park@...sung.com>

On Wed, Aug 4, 2010 at 3:34 PM, Axel Lin <axel.lin@...il.com> wrote:
> In max8998_list_voltage() and max8998_set_voltage(),
> we use ldo as array index of ldo_voltage_map.
> Thus the valid range should be 0 .. ARRAY_SIZE(ldo_voltage_map)-1.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/regulator/max8998.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c
> index 03e55a1..ab67298 100644
> --- a/drivers/regulator/max8998.c
> +++ b/drivers/regulator/max8998.c
> @@ -119,7 +119,7 @@ static int max8998_list_voltage(struct regulator_dev *rdev,
>        int ldo = max8998_get_ldo(rdev);
>        int val;
>
> -       if (ldo > ARRAY_SIZE(ldo_voltage_map))
> +       if (ldo >= ARRAY_SIZE(ldo_voltage_map))
>                return -EINVAL;
>
>        desc = ldo_voltage_map[ldo];
> @@ -306,7 +306,7 @@ static int max8998_set_voltage(struct regulator_dev *rdev,
>        u8 val;
>        bool en_ramp = false;
>
> -       if (ldo > ARRAY_SIZE(ldo_voltage_map))
> +       if (ldo >= ARRAY_SIZE(ldo_voltage_map))
>                return -EINVAL;
>
>        desc = ldo_voltage_map[ldo];
> --
> 1.5.4.3
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/