lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 4 Aug 2010 10:05:03 -0700
From:	Greg KH <gregkh@...e.de>
To:	Hank Janssen <hjanssen@...rosoft.com>
Cc:	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"'devel@...verdev.osuosl.org'" <devel@...verdev.osuosl.org>,
	"'virtualization@...ts.osdl.org'" <virtualization@...ts.osdl.org>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH 2/6] staging: hv: Fixed lockup problem with
 bounce_buffer scatter list

On Wed, Aug 04, 2010 at 04:32:17AM +0000, Hank Janssen wrote:
> And then Greg spoke:
> >> On Tue, Aug 03, 2010 at 05:31:53PM +0000, Hank Janssen wrote:
> >> From: Hank Janssen <hjanssen@...rosoft.com>
> > >
> > >Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads.
> >
> >Same questions for you as patch 1/6.
> >
> >Also, please wrap your changelog comments at 72 columns.
>  
> Under heavy loads with many clients we this problem appears, it causes a kernel 
> Panic.

Great, please provide this info.

> Yes, this should be backported to all stable kernel releases that have the 
> Hyper-V drivers In them.  

Again, add a cc: stable <stable@...nel.org> to the patch please.

> >> Signed-off-by:Hank Janssen <hjanssen@...rosoft.com> 
> >> Signed-off-by:Haiyang Zhang <haiyangz@...rosoft.com>
> >
> >What's with the trailing space?
> 
> Same problem as wrapping my comments at 72  chars, I just upgraded to the latest
> Evil outlook 2010, and my settings in office 2007 did not transfer so I have to 
> Set up all the stuff that fixes these problems :(
> 
> Do you want me to re-submit with correct wrapping?

Yes.  But you also have trailing spaces in some of these patches as
well, which need to be addressed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ