linux-kernel - Re: [RFC][PATCH -mm] hibernation: freeze swap at hibernation (Was Re: Memory corruption during hibernation since 2.6.31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100804112629.780e512a.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 4 Aug 2010 11:26:29 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>, Hugh Dickins <hughd@...gle.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Ondrej Zary <linux@...nbow-software.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Balbir Singh <balbir@...ibm.com>,
	Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: [RFC][PATCH -mm] hibernation: freeze swap at hibernation (Was
 Re: Memory corruption during hibernation since 2.6.31

On Wed, 4 Aug 2010 08:31:19 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:

> On Wed, 4 Aug 2010 01:09:15 +0200
> "Rafael J. Wysocki" <rjw@...k.pl> wrote:
> 
> > On Monday, August 02, 2010, KAMEZAWA Hiroyuki wrote:
> > > On Fri, 30 Jul 2010 13:14:32 +0900
> > > KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:
> > > 
> > > > On Thu, 29 Jul 2010 21:10:10 -0700
> > > > Hugh Dickins <hughd@...gle.com> wrote:
> > > > 
> > > > > On Thu, Jul 29, 2010 at 5:01 PM, KAMEZAWA Hiroyuki
> > > > > <kamezawa.hiroyu@...fujitsu.com> wrote:
> > > > > 
> > > > > > I think the best way is kexec(). But maybe rollback from hibernation failure
> > > > > > will be difficult. Considering how crash-dump works well and under maintainance
> > > > > > by many enterprise guys, hibernation-by-kexec is a choice. I think. It can make
> > > > > > reuse of kdump code, ...or, hibernation-resume code can eat kdump image
> > > > > > directly. Maybe the problem will be the speed of dump.
> > > > > 
> > > > > I've no appetite for a total rework of hibernation, and I don't see
> > > > > how that would
> > > > > address the issue: I'm just looking for some protection against swap
> > > > > reuse danger.
> > > > > 
> > > > Okay ;) (And I forget that kexec has to prepare memory at boot time for 2nd kernel.
> > > > It will be harmful for small device guys.)
> > > > 
> > > > I'll prepare a routine not-quick-fix.
> > > 
> > > Ok, here. Passed easy tests as
> > > # echo disk > /sys/power/state
> > > 

Sorry, I found this patch is of no use. I should put
hibernate_free_swap() before hibernation_snapshot().

I'll retry.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/