linux-kernel - Re: [PATCHv3 16/16] pps: add parallel port PPS signal generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100804163804.fce2ffd6.akpm@linux-foundation.org>
Date:	Wed, 4 Aug 2010 16:38:04 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alexander Gordeev <lasaine@....cs.msu.su>
Cc:	linux-kernel@...r.kernel.org,
	"Nikita V\. Youshchenko" <yoush@...msu.su>,
	linuxpps@...enneenne.com, Rodolfo Giometti <giometti@...eenne.com>,
	john stultz <johnstul@...ibm.com>
Subject: Re: [PATCHv3 16/16] pps: add parallel port PPS signal generator

On Thu,  5 Aug 2010 01:06:53 +0400
Alexander Gordeev <lasaine@....cs.msu.su> wrote:

> Add PPS signal generator which utilizes STROBE pin of a parallel port to
> send PPS signals. It uses parport abstraction layer and hrtimers to
> precisely control the signal.
> 
> ..
>
> +static unsigned int send_delay = 30000;
> +MODULE_PARM_DESC(delay,
> +	"Delay between setting and dropping the signal (ns)");
> +module_param_named(delay, send_delay, uint, 0);

This code doesn't look easy to configure and use.  For example, if some
random person tries to get it going, how does he even know that this
module parameter exists, let alone how to use it?

Please review Documentation/pps/pps.txt and check that it accurately
and completely describes how to use the pps code after your changes,
thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/