linux-kernel - Re: [PATCH 1/2] usb gadget: don't save bind callback in struct usb_gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <op.vgyi8eix7p4s8u@pikus>
Date:	Thu, 05 Aug 2010 10:58:52 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	linux-usb@...r.kernel.org,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 1/2] usb gadget: don't save bind callback in struct
 usb_gadget_driver

On Mon, 02 Aug 2010 20:27:45 +0200, Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
> diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
> @@ -2045,7 +2045,6 @@ static void __exit udc_exit(void)
>  }
> EXPORT_SYMBOL(usb_gadget_unregister_driver);
> -EXPORT_SYMBOL(usb_gadget_register_driver);

*IF* you are going to send an updated patch, how about removing
empty line above this EXPORT_SYMBOL().


So for what it's worth the changes look good to me.

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/