linux-kernel - Re: [PATCH] stop_machine: struct cpu_stopper, remove alignment padding on 64 bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1281008435.1923.1820.camel@laptop>
Date:	Thu, 05 Aug 2010 13:40:35 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Richard Kennedy <richard@....demon.co.uk>
Cc:	Tejun Heo <tj@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] stop_machine: struct cpu_stopper, remove alignment
 padding on 64 bits

On Thu, 2010-08-05 at 12:11 +0100, Richard Kennedy wrote:
> Reorder elements in structure cpu_stopper to remove alignment padding on
> 64 bit builds, this shrinks its size from 40 to 32 bytes saving 8 bytes
> per cpu.
> 
> Signed-off-by: Richard Kennedy <richard@....demon.co.uk>

Looks good to me. Tejun will you take it or should I send it Ingo wards?

> ---
> diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
> index 70f8d90..4372ccb 100644
> --- a/kernel/stop_machine.c
> +++ b/kernel/stop_machine.c
> @@ -35,9 +35,9 @@ struct cpu_stop_done {
>  /* the actual stopper, one per every possible cpu, enabled on online cpus */
>  struct cpu_stopper {
>  	spinlock_t		lock;
> +	bool			enabled;	/* is this stopper enabled? */
>  	struct list_head	works;		/* list of pending works */
>  	struct task_struct	*thread;	/* stopper thread */
> -	bool			enabled;	/* is this stopper enabled? */
>  };
>  
>  static DEFINE_PER_CPU(struct cpu_stopper, cpu_stopper);
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/