linux-kernel - Re: [PATCH] arch/powerpc: Drop unnecessary of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Aug 2010 18:01:08 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Julia Lawall <julia@...u.dk>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] arch/powerpc: Drop unnecessary of_node_put

On Tue, Aug 3, 2010 at 1:50 PM, Julia Lawall <julia@...u.dk> wrote:
> From: Julia Lawall <julia@...u.dk>
>
> for_each_node_by_name only exits when its first argument is NULL, and a
> subsequent call to of_node_put on that argument is unnecessary.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> iterator name for_each_node_by_name;
> expression np,E;
> identifier l;
> @@
>
> for_each_node_by_name(np,...) {
>  ... when != break;
>      when != goto l;
> }
> ... when != np = E
> - of_node_put(np);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@...u.dk>

Looks correct to me:

Reviewed-by: Grant Likely <grant.likely@...retlab.ca>

>
> ---
>  arch/powerpc/platforms/powermac/feature.c |    1 -
>  arch/powerpc/platforms/powermac/pci.c     |    2 --
>  2 files changed, 3 deletions(-)
>
> diff -u -p a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
> --- a/arch/powerpc/platforms/powermac/feature.c
> +++ b/arch/powerpc/platforms/powermac/feature.c
> @@ -2872,7 +2872,6 @@ set_initial_features(void)
>                                core99_airport_enable(np, 0, 0);
>                        }
>                }
> -               of_node_put(np);
>        }
>
>        /* On all machines that support sound PM, switch sound off */
> diff -u -p a/arch/powerpc/platforms/powermac/pci.c b/arch/powerpc/platforms/powermac/pci.c
> --- a/arch/powerpc/platforms/powermac/pci.c
> +++ b/arch/powerpc/platforms/powermac/pci.c
> @@ -1155,13 +1155,11 @@ void __init pmac_pcibios_after_init(void
>                        pmac_call_feature(PMAC_FTR_1394_CABLE_POWER, nd, 0, 0);
>                }
>        }
> -       of_node_put(nd);
>        for_each_node_by_name(nd, "ethernet") {
>                if (nd->parent && of_device_is_compatible(nd, "gmac")
>                    && of_device_is_compatible(nd->parent, "uni-north"))
>                        pmac_call_feature(PMAC_FTR_GMAC_ENABLE, nd, 0, 0);
>        }
> -       of_node_put(nd);
>  }
>
>  void pmac_pci_fixup_cardbus(struct pci_dev* dev)
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/