linux-kernel - Re: [PATCH v3 3/3] init: add support for root devices specified by partition UUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C5ACAAD.1030305@kernel.org>
Date:	Thu, 05 Aug 2010 16:29:01 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Will Drewry <wad@...omium.org>
CC:	linux-kernel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org>,
	Jens Axboe <axboe@...nel.dk>, Karel Zak <kzak@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>, Jan Blunck <jblunck@...e.de>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH v3 3/3] init: add support for root devices specified by
 	partition UUID

Hello,

On 08/05/2010 04:26 PM, Will Drewry wrote:
> On Thu, Aug 5, 2010 at 5:55 AM, Tejun Heo <tj@...nel.org> wrote:
>> Hello,
>>
>> On 08/04/2010 08:22 PM, Will Drewry wrote:
>>> @@ -642,6 +642,7 @@ void __init printk_all_partitions(void)
>>>               struct hd_struct *part;
>>>               char name_buf[BDEVNAME_SIZE];
>>>               char devt_buf[BDEVT_SIZE];
>>> +             u8 uuid[PARTITION_META_INFO_UUIDLTH * 2 + 1];
>>>
>>>               /*
>>>                * Don't show empty devices or things that have been
>>> @@ -660,10 +661,14 @@ void __init printk_all_partitions(void)
>>>               while ((part = disk_part_iter_next(&piter))) {
>>>                       bool is_part0 = part == &disk->part0;
>>>
>>> -                     printk("%s%s %10llu %s", is_part0 ? "" : "  ",
>>> +                     uuid[0] = 0;
>>> +                     if (part->info)
>>> +                             part_unpack_uuid(part->info->uuid, uuid);
>>> +
>>> +                     printk("%s%s %10llu %s %s", is_part0 ? "" : "  ",
>>>                              bdevt_str(part_devt(part), devt_buf),
>>>                              (unsigned long long)part->nr_sects >> 1,
>>> -                            disk_name(disk, part->partno, name_buf));
>>> +                            disk_name(disk, part->partno, name_buf), uuid);
>>
>> Hmmm... I'm a bit worried about this.  This might break userspace
>> tools.  I think it would be better to export it via sysfs.
> 
> Cool - I'm happy to drop that part from the patch.  I was more
> following the spirit of the comment around making it easy for a user
> to figure out what went wrong (e.g., wrong uuid) if they don't have a
> root, but if there are tools parsing that output, I'd rather not break
> them!

Oh, forget about what I said.  For some reason I thought the above
code was for /proc/partitions.  :-)

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/