| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4C5B00A2.5020802@oracle.com> Date: Thu, 05 Aug 2010 11:19:14 -0700 From: Randy Dunlap <randy.dunlap@...cle.com> To: Nir Tzachar <nir.tzachar@...il.com> CC: mmarek@...e.cz, linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, sam@...nborg.org Subject: Re: [PATCH] nconfig: add search support On 08/05/10 11:13, Nir Tzachar wrote: > On Thu, Aug 5, 2010 at 8:04 PM, Randy Dunlap <randy.dunlap@...cle.com> wrote: >> On Tue, 3 Aug 2010 15:28:12 +0300 nir.tzachar@...il.com wrote: >> >>> From: Nir Tzachar <nir.tzachar@...il.com> >>> >>> Remove the old hotkeys feature, and replace by a regular string search. >>> Behaviour of search is as advised by Sam. >>> >>> From nconfig help: >>> >>> Searching: pressing '/' triggers search mode. nconfig performs a >>> regular string compare, case insensitive, starting at >> >> I would say: simple string compare >> "regular" has no meaning (at least for me) there. > > Regular means strcasecmp... That's not meaningful to a non-developer user. I'm a developer and it still has little meaning to me in this context. >>> the beginning of each menu line.\n" >>> Pressing the up/down keys highlights the previous/next >>> matching item. Backspace removes one character from the >>> match string. Pressing either '/' again or ESC exits\ >>> search mode. All other keys behave normally. >>> >>> Miscellaneous other changes (including Rundy's Justin's input). >> >> Yes, the bottom menu and the typos are fixed. Thanks. >> >> However, I'm not finding this terribly useful, mostly due to it starting >> comparison at the beginning of each menu line. >> >> E.g., I'd like to be able to find "emulations" in the top-level menu here: >> Executable file formats / Emulations ---> >> or I'd like to be able to find "crc" menu items in any sub-menu. >> Maybe I should just stick to config symbol searches. I don't think it's all >> that likely that people will know how each menu line text begins. >> >> > > We can replace strcasecmp with strcasestr. I agree it would be more useful. Yes. >> As for the search UI, I'd rather that it be presented like the symbol search, >> in a box, instead of just a single line at the top of the screen. > > But then it is not interactive. I was aiming for something similar to > vim's search, where the search is matched as you type and the only > free terminal real-estate to display the match string was at the top > of the screen. I think such a minimal design is better than a > cumbersome text box which displays the search results afterwards (as > is symbol search), as the search is only intended for the currently > displayed menu and the user would usually just want to save the extra > typing of navigating to a specific menu item. OK, I expect that I'll just mostly use symbol search instead of this one then. The kicker for me is not how/where the dialog is -- it's this comment: "as the search is only intended for the currently displayed menu" I think that's much too limiting. > Cheers. > >>> Signed-off-by: Nir Tzachar <nir.tzachar@...il.com> >>> --- >>> scripts/kconfig/nconf.c | 350 +++++++++++++++++++++++++------------------ >>> scripts/kconfig/nconf.gui.c | 20 ++-- >>> scripts/kconfig/nconf.h | 3 +- >>> 3 files changed, 213 insertions(+), 160 deletions(-) -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists