linux-kernel - Re: [PATCH -next] apparmor: depends on NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1008051313500.8765@tundra.namei.org>
Date:	Thu, 5 Aug 2010 13:15:16 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	John Johansen <john.johansen@...onical.com>
cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH -next] apparmor: depends on NET

On Mon, 2 Aug 2010, John Johansen wrote:

> On 08/02/2010 10:52 AM, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > SECURITY_APPARMOR should depend on NET since AUDIT needs
> > (depends on) NET.
> > 
> yes, thanks .that depends seems to have been dropped when I
> split out networking hooks for later submission
> 
> Signed-off-by: John Johansen <john.johansen@...onical.com>

Thanks, I'll fix these up in the next day or so now that the code is 
merged with Linus.


> 
> > Fixes 70-80 errors that occur when CONFIG_NET is not enabled,
> > but APPARMOR selects AUDIT without qualification.  E.g.:
> > 
> > audit.c:(.text+0x33361): undefined reference to `netlink_unicast'
> > (.text+0x333df): undefined reference to `netlink_unicast'
> > audit.c:(.text+0x3341d): undefined reference to `skb_queue_tail'
> > audit.c:(.text+0x33424): undefined reference to `kfree_skb'
> > audit.c:(.text+0x334cb): undefined reference to `kfree_skb'
> > audit.c:(.text+0x33597): undefined reference to `skb_put'
> > audit.c:(.text+0x3369b): undefined reference to `__alloc_skb'
> > audit.c:(.text+0x336d7): undefined reference to `kfree_skb'
> > (.text+0x3374c): undefined reference to `__alloc_skb'
> > auditfilter.c:(.text+0x35305): undefined reference to `skb_queue_tail'
> > lsm_audit.c:(.text+0x2873): undefined reference to `init_net'
> > lsm_audit.c:(.text+0x2878): undefined reference to `dev_get_by_index'
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> > Cc: John Johansen <john.johansen@...onical.com>
> > ---
> >  security/apparmor/Kconfig |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-next-20100802.orig/security/apparmor/Kconfig
> > +++ linux-next-20100802/security/apparmor/Kconfig
> > @@ -1,6 +1,6 @@
> >  config SECURITY_APPARMOR
> >  	bool "AppArmor support"
> > -	depends on SECURITY
> > +	depends on SECURITY && NET
> >  	select AUDIT
> >  	select SECURITY_PATH
> >  	select SECURITYFS
> 

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/