lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201008052257.54039.ppisa4lists@pikron.com>
Date:	Thu, 5 Aug 2010 22:57:53 +0200
From:	Pavel Pisa <ppisa4lists@...ron.com>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Julia Lawall <julia@...u.dk>, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 10/42] drivers/mmc/host: Adjust confusing if indentation

On Thursday 05 August 2010 22:19:52 Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
...
> Signed-off-by: Julia Lawall <julia@...u.dk>
Acked-by: Pavel Pisa <pisa@....felk.cvut.cz>

Good catch.

> ---
>  drivers/mmc/host/imxmmc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/imxmmc.c b/drivers/mmc/host/imxmmc.c
> index 9a68ff4..5a950b1 100644
> --- a/drivers/mmc/host/imxmmc.c
> +++ b/drivers/mmc/host/imxmmc.c
> @@ -148,11 +148,12 @@ static int imxmci_start_clock(struct imxmci_host
> *host)
>
>  		while (delay--) {
>  			reg = readw(host->base + MMC_REG_STATUS);
> -			if (reg & STATUS_CARD_BUS_CLK_RUN)
> +			if (reg & STATUS_CARD_BUS_CLK_RUN) {
>  				/* Check twice before cut */
>  				reg = readw(host->base + MMC_REG_STATUS);
>  				if (reg & STATUS_CARD_BUS_CLK_RUN)
>  					return 0;
> +			}
>
>  			if (test_bit(IMXMCI_PEND_STARTED_b, &host->pending_events))
>  				return 0;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
                Pavel Pisa
    e-mail:     pisa@....felk.cvut.cz
    www:        http://cmp.felk.cvut.cz/~pisa
    university: http://dce.fel.cvut.cz/
    company:    http://www.pikron.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ