linux-kernel - Re: [spi-devel-general] [PATCH 26/42] drivers/spi/amba-pl022.c: Adjust confusing if indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTinCCrrdEXMTdPiFp4Y4gE4zqNVYQZFFSXWEmH-r@mail.gmail.com>
Date:	Thu, 5 Aug 2010 23:41:03 +0200
From:	Linus Walleij <linus.walleij@...ricsson.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	David Brownell <david-b@...bell.net>,
	spi-devel-general@...ts.sourceforge.net,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [spi-devel-general] [PATCH 26/42] drivers/spi/amba-pl022.c: 
	Adjust confusing if indentation

2010/8/5 Julia Lawall <julia@...u.dk>:

> From: Julia Lawall <julia@...u.dk>
>
> The return -EINVAL appears to only make sense if the if branch that it is
> aligned with is taken, so move it into that branch

What a nasty bug to see, thanks for robot-finding this!
Acked-by: Linus Walleij <linus.walleij@...ricsson.com>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/