[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100805172711.87c802ca.akpm@linux-foundation.org>
Date: Thu, 5 Aug 2010 17:27:11 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc: Michael Rubin <mrubin@...gle.com>, linux-kernel@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, jack@...e.cz,
david@...morbit.com, hch@....de, axboe@...nel.dk
Subject: Re: [PATCH 2/2] writeback: Adding pages_dirtied and
pages_entered_writeback
On Fri, 6 Aug 2010 09:18:59 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:
> > On Thu, Aug 5, 2010 at 4:56 PM, KOSAKI Motohiro
> > <kosaki.motohiro@...fujitsu.com> wrote:
> > > /proc/vmstat already have both.
> > >
> > > cat /proc/vmstat |grep nr_dirty
> > > cat /proc/vmstat |grep nr_writeback
> > >
> > > Also, /sys/devices/system/node/node0/meminfo show per-node stat.
> > >
> > > Perhaps, I'm missing your point.
> >
> > These only show the number of dirty pages present in the system at the
> > point they are queried.
> > The counter I am trying to add are increasing over time. They allow
> > developers to see rates of pages being dirtied and entering writeback.
> > Which is very helpful.
>
> Usually administrators get the data two times and subtract them. Isn't it sufficient?
>
Nope. The existing nr_dirty is "number of pages dirtied since boot"
minus "number of pages cleaned since boot". If you do the
wait-one-second-then-subtract thing on nr_dirty, the result is
dirtying-bandwidth minus cleaning-bandwidth, and can't be used to
determine dirtying-bandwidth.
I can see that a graph of dirtying events versus time could be an
interesting thing. I don't see how it could be obtained using the
existing instrumentation. tracepoints, probably..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists