linux-kernel - Re: [PATCH 2/2 v2] usb gadget: don't save bind callback in struct usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <op.vg0dccfk7p4s8u@pikus>
Date:	Fri, 06 Aug 2010 10:46:50 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Greg KH <greg@...ah.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 2/2 v2] usb gadget: don't save bind callback in struct
 usb_configuration

On Fri, 06 Aug 2010 00:34:35 +0200, Greg KH <greg@...ah.com> wrote:

> On Thu, Aug 05, 2010 at 11:50:17AM +0200, Uwe Kleine-König wrote:
>> The bind function is most of the time only called at init time so there is no
>> need to save a pointer to it in the configuration structure.
>>
>> This fixes many section mismatches reported by modpost.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>> Cc: Michał Nazarewicz <m.nazarewicz@...sung.com>
>> Cc: Greg Kroah-Hartman <gregkh@...e.de>
>> ---
>> changes since v1:
>
> I'm confused, can you resend what you want me to apply please?
>
> Do I need to drop Michał's patch before applying yours?

Yep.  Uwe's patches seem to be a better solution for fixing the section
mismatch.  They remove the need of __ref* tags.  I looked through them
and they seem fine to me.

(Also, as I realised a minute ago, my patch is incorrect.)

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/