linux-kernel - Re: [PATCH RESEND] Fix /proc/softirqs file formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1281106336.1945.0.camel@cowboy>
Date:	Fri, 06 Aug 2010 10:52:16 -0400
From:	Davidlohr Bueso <dave@....org>
To:	Keika Kobayashi <kobayashi.kk@...s.nec.co.jp>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH RESEND] Fix /proc/softirqs file formatting

On Mon, 2010-08-02 at 08:51 +0900, Keika Kobayashi wrote:
> (2010/07/31 4:06), Davidlohr Bueso wrote:
> > Hi,
> > 
> > The length of the BLOCK_IPOLL string is making it's value be printed too
> > far to the right. This patch fixes this and makes the output a bit
> > neater.
> > 
> > Currently:
> >                 CPU0
> >       HI:          0
> >    TIMER:     599792
> >   NET_TX:          2
> >   NET_RX:          6
> >    BLOCK:      80807
> > BLOCK_IOPOLL:          0
> >  TASKLET:      20012
> >    SCHED:          0
> >  HRTIMER:         63
> >      RCU:     619279
> > 
> > With patch:
> >                     CPU0
> >           HI:          0
> >        TIMER:     585582
> >       NET_TX:          2
> >       NET_RX:          6
> >        BLOCK:      80320
> > BLOCK_IOPOLL:          0
> >      TASKLET:      19287
> >        SCHED:          0
> >      HRTIMER:         62
> >          RCU:     604441
> > 
> > 
> > 
> > Thanks,
> > Davidlohr
> >  
> > 
> > Signed-off-by: Davidlohr Bueso <dave@....org>
> > ---
> >  fs/proc/softirqs.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/fs/proc/softirqs.c b/fs/proc/softirqs.c
> > index 1807c24..3799473 100644
> > --- a/fs/proc/softirqs.c
> > +++ b/fs/proc/softirqs.c
> > @@ -10,13 +10,13 @@ static int show_softirqs(struct seq_file *p, void *v)
> >  {
> >  	int i, j;
> >  
> > -	seq_printf(p, "                ");
> > +	seq_printf(p, "                    ");
> >  	for_each_possible_cpu(i)
> >  		seq_printf(p, "CPU%-8d", i);
> >  	seq_printf(p, "\n");
> >  
> >  	for (i = 0; i < NR_SOFTIRQS; i++) {
> > -		seq_printf(p, "%8s:", softirq_to_name[i]);
> > +		seq_printf(p, "%12s:", softirq_to_name[i]);
> >  		for_each_possible_cpu(j)
> >  			seq_printf(p, " %10u", kstat_softirqs_cpu(i, j));
> >  		seq_printf(p, "\n");
> 
> Sorry for late response.
> 
> It looks good to me.
> 
> // Keika Kobayashi

Then, if no one objects, can we get it added upstream?

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/