linux-kernel - Re: [RFC PATCH 4/9] mce: Add persistent events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1281106636.1947.710.camel@laptop>
Date:	Fri, 06 Aug 2010 16:57:16 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Borislav Petkov <bp@...64.org>
Cc:	acme@...radead.org, fweisbec@...il.com, mingo@...e.hu,
	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	Borislav Petkov <borislav.petkov@....com>
Subject: Re: [RFC PATCH 4/9] mce: Add persistent events

On Fri, 2010-08-06 at 16:25 +0200, Borislav Petkov wrote:
> +static const struct file_operations perf_mce_fops = {
> +       .llseek         = no_llseek,
> +       .open           = mce_perf_open,
> +       .poll           = perf_poll,
> +       .unlocked_ioctl = perf_ioctl,
> +       .compat_ioctl   = perf_ioctl,
> +       .mmap           = perf_mmap,
> +       .fasync         = perf_fasync,
> +       .release        = perf_release,
> +}; 

I'd rather see this part of the persistent bits live in
kernel/perf_event.c, that way you don't need the previous patch either.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/