linux-kernel - Re: [PATCH 11/18] pcmcia: pd6729: call disable_pci_device() if pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100807112918.GB17845@isilmar-3.linta.de>
Date:	Sat, 7 Aug 2010 13:29:18 +0200
From:	Dominik Brodowski <linux@...inikbrodowski.net>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	kernel-janitors@...r.kernel.org, Komuro <komurojun-mbn@...ty.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	"David S. Miller" <davem@...emloft.net>, Tejun Heo <tj@...nel.org>,
	linux-pcmcia@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/18] pcmcia: pd6729: call disable_pci_device() if
	pci_probe() failed

On Fri, Aug 06, 2010 at 11:52:44PM +0400, Kulikov Vasiliy wrote:
> Driver should call disable_pci_device() if it returns from pci_probe()
> with error. Also it must not be called if pci_request_region() fails as
> it means that somebody uses device resources and rules the device.

But that would mean that a driver first enables a device, then fails to make
use of it, and then can't disable it? This doesn't look right to me. The
first part of the patch looks fine, though.

Best,
	Dominik


> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
> ---
>  drivers/pcmcia/pd6729.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c
> index b8a869a..1858c3a 100644
> --- a/drivers/pcmcia/pd6729.c
> +++ b/drivers/pcmcia/pd6729.c
> @@ -646,7 +646,7 @@ static int __devinit pd6729_pci_probe(struct pci_dev *dev,
>  	if (!pci_resource_start(dev, 0)) {
>  		dev_warn(&dev->dev, "refusing to load the driver as the "
>  			"io_base is NULL.\n");
> -		goto err_out_free_mem;
> +		goto err_out_disable;
>  	}
>  
>  	dev_info(&dev->dev, "Cirrus PD6729 PCI to PCMCIA Bridge at 0x%llx "
> @@ -666,7 +666,7 @@ static int __devinit pd6729_pci_probe(struct pci_dev *dev,
>  	ret = pci_request_regions(dev, "pd6729");
>  	if (ret) {
>  		dev_warn(&dev->dev, "pci request region failed.\n");
> -		goto err_out_disable;
> +		goto err_out_free_mem;
>  	}
>  
>  	if (dev->irq == NO_IRQ)
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/