linux-kernel - Re: [PATCH] i2c: cyttsp i2c and spi touchscreen driver init submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C5CAD84.2040804@euromail.se>
Date:	Sat, 07 Aug 2010 02:49:08 +0200
From:	Henrik Rydberg <rydberg@...omail.se>
To:	Kevin McNeely <Kevin.McNeely@...ress.com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	David Brown <davidb@...eaurora.org>,
	Trilok Soni <tsoni@...eaurora.org>,
	Fred <fwk@...ntu.linuxcertified.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Eric Miao <eric.y.miao@...il.com>,
	Ben Dooks <ben-linux@...ff.org>,
	Simtec Linux Team <linux@...tec.co.uk>,
	Todd Fischer <todd.fischer@...gerun.com>,
	Arnaud Patard <arnaud.patard@...-net.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: cyttsp i2c and spi touchscreen driver init submit

On 08/07/2010 02:32 AM, Kevin McNeely wrote:

[...]

> However, I would like to keep the MT Protocol A.  Our solution allows

> The platform builder to select to use MT protocol B or not as part of 
> platform_data in the board configuration. If it makes more sense,
> I can reverse the code to default to protocol B and allow the platform
> builder developer to select protocol A.


There is nothing preventing you from keeping say a dkms package somewhere with
all options intact. However, for the kernel, it is a question of
maintainability. If the driver can produce prefectly valid data using protocol
B, and by doing so several hundred lines of code can be removed, that is very
much preferred. Since both protocols can be translated to protocol B via mtdev,
which is already very much in use, there is little reason to support protocol A
when the device can do tracking.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/