linux-kernel - Re: [PATCH] lockup_detector: Make DETECT_HUNT_TASK default depend on LOCKUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 8 Aug 2010 23:47:47 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Heiko Carstens <heiko.carstens@...ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Li Zefan <lizf@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Don Zickus <dzickus@...hat.com>
Subject: Re: [PATCH] lockup_detector: Make DETECT_HUNT_TASK default depend
	on LOCKUP_DETECTOR

On Sun, Aug 08, 2010 at 11:23:11PM +0200, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <fweisbec@...il.com> wrote:
> 
> > > The thing is, CONFIG_DETECT_SOFTLOCKUP was default-y before, so many 
> > > people had it enabled [and had it forced-enabled if DEBUG_KERNEL was off], 
> > > even if they didnt really want or need it.
> > 
> > Hmm. It was:
> > 
> > config DETECT_SOFTLOCKUP
> > 	bool "Detect Soft Lockups"
> > 	depends on DEBUG_KERNEL && !S390
> > 	default y
> > 
> > It means it's default enabled only if DEBUG_KERNEL, right? Then if you don't 
> > select CONFIG_DEBUG_KERNEL, it's fine as it won't be selected.
> 
> Indeed, you are right.
> 
> Anyway, i think the general point remains: i'm not sure we should 
> default-enable this feature.



Yeah, right.


 
> > But I agree with you. There is a bunch of config options for which selection 
> > is a duty when you are a kernel developer: PROVE_LOCKING, DETECT_HUNG_TASK, 
> > DEBUG_PREEMPT, PROVE_RCU, etc... Because they all show (or prove we can 
> > have) bugs that one might miss without these options. Softlockups are rarely 
> > part of them because even without the lockup detector enabled, you'll 
> > observe something is wrong.
> 
> Note that it's now detecting all kinds of lockups: softlockups, hard lockups 
> and even unkillable hung tasks.
> 
> 	Ingo



The unkillable hung task detector remains seperate. May be from the config point
of view it could be joined, but from an implementation point of view it has too
few to share with the lockup detector: it doesn't need a real time task, nor
a timer, etc...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/