linux-kernel - Re: [patch] lpfc: change spin_lock_irq() to spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C600AAE.8030507@emulex.com>
Date:	Mon, 9 Aug 2010 10:03:26 -0400
From:	James Smart <james.smart@...lex.com>
To:	Dan Carpenter <error27@...il.com>,
	James Smart <james.smart@...lex.com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	Alex Iannicelli <alex.iannicelli@...lex.com>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [patch] lpfc: change spin_lock_irq() to spin_lock()



Dan Carpenter wrote:
> In lpfc_cleanup_pending_mbox() we already have IRQs disabled so we don't
> need to disable them again.
> 
> Also in lpfc_sli_intr_handler() there is a typo where it has
> spin_unlock_irq() instead of just spin_unlock().
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
> 
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c

Acked-by: James Smart <james.smart@...lex.com>

Thank You.

-- james s
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/