linux-kernel - RE: [PATCH 34/42] drivers/message/fusion: Adjust confusing if indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1C9608B8A4CD534FB19C7C7543CBB24902991CD598@inbmail02.lsi.com>
Date:	Mon, 9 Aug 2010 19:49:40 +0530
From:	"Desai, Kashyap" <Kashyap.Desai@....com>
To:	Julia Lawall <julia@...u.dk>, "Moore, Eric" <Eric.Moore@....com>,
	"Support, Software" <support@....com>,
	DL-MPT Fusion Linux <DL-MPTFusionLinux@....com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH 34/42] drivers/message/fusion: Adjust confusing if
 indentation



> -----Original Message-----
> From: Julia Lawall [mailto:julia@...u.dk]
> Sent: Friday, August 06, 2010 1:57 AM
> To: Moore, Eric; Support, Software; DL-MPT Fusion Linux; linux-
> scsi@...r.kernel.org; linux-kernel@...r.kernel.org; kernel-
> janitors@...r.kernel.org
> Subject: [PATCH 34/42] drivers/message/fusion: Adjust confusing if
> indentation
> 
> From: Julia Lawall <julia@...u.dk>
> 
> Indent the branch of an if.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
> 
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
> 
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
> 
> if (p1[0].column == p2[0].column):
>   cocci.print_main("branch",p1)
>   cocci.print_secs("after",p2)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  drivers/message/fusion/mptbase.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/message/fusion/mptbase.c
> b/drivers/message/fusion/mptbase.c
> index d8c668d..92e4b25 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -8049,7 +8049,7 @@ union loginfo_type {
>  			code_desc = ir_code_str[sas_loginfo.dw.code];
>  			if (sas_loginfo.dw.subcode >=
>  			    ARRAY_SIZE(raid_sub_code_str))
> -			break;
> +				break;
Agree. Please consider this patch as an ACKed.
Thanks, Kashyap
>  			if (sas_loginfo.dw.code == 0)
>  				sub_code_desc =
>  				    raid_sub_code_str[sas_loginfo.dw.subcode];
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/