linux-kernel - RE: [PATCH] scsi: mpt2sas: Add space in printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1008091644280.28909@ask.diku.dk>
Date:	Mon, 9 Aug 2010 16:45:19 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	"Desai, Kashyap" <Kashyap.Desai@....com>
Cc:	Dan Carpenter <error27@...il.com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"Moore, Eric" <Eric.Moore@....com>
Subject: RE: [PATCH] scsi: mpt2sas: Add space in printk

On Mon, 9 Aug 2010, Desai, Kashyap wrote:

> 
> 
> > -----Original Message-----
> > From: Dan Carpenter [mailto:error27@...il.com]
> > Sent: Friday, August 06, 2010 1:29 PM
> > To: Julia Lawall
> > Cc: James E.J. Bottomley; linux-scsi@...r.kernel.org; linux-
> > kernel@...r.kernel.org; kernel-janitors@...r.kernel.org; Moore, Eric;
> > Desai, Kashyap
> > Subject: [PATCH] scsi: mpt2sas: Add space in printk
> > 
> > Add a space in the output:
> > old:  Discovery: (stop)discovery_status(0x%08x)
> > new:  Discovery: (stop) discovery_status(0x%08x)
> > 
> > Signed-off-by: Dan Carpenter <error27@...il.com>
> > ---
> > This goes on top of Julia's [PATCH 9/42] drivers/scsi: Adjust
> > confusing if indentation
> > 
> > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c
> > b/drivers/scsi/mpt2sas/mpt2sas_base.c
> > index 12faf64..562b909 100644
> > --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> > +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> > @@ -532,7 +532,7 @@ _base_display_event_data(struct MPT2SAS_ADAPTER
> > *ioc,
> >  		    (event_data->ReasonCode ==
> > MPI2_EVENT_SAS_DISC_RC_STARTED) ?
> >  		    "start" : "stop");
> >  		if (event_data->DiscoveryStatus)
> > -			printk("discovery_status(0x%08x)",
> > +			printk(" discovery_status(0x%08x)",
> I don't see any significant reason for changing print. It not adding any benefit.

It would look a little nicer to have a space after the ) that is printed 
by the previous statement.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/