linux-kernel - Re: [tip:x86/cpu] x86, cpu: RDC doesn't have CPUID, which is what c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C6061DE.4030300@linux.intel.com>
Date:	Mon, 09 Aug 2010 13:15:26 -0700
From:	"H. Peter Anvin" <hpa@...ux.intel.com>
To:	bifferos <bifferos@...oo.co.uk>
CC:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	florian@...nwrt.org, mark@...feros.com, tglx@...utronix.de,
	Ingo Molnar <mingo@...e.hu>, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/cpu] x86, cpu: RDC doesn't have CPUID, which is what
 c_ident is

On 08/09/2010 02:33 AM, bifferos wrote:
> 
> The quick fix for this is:
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 490dac6..06a2dac 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -497,6 +497,9 @@ static void __cpuinit get_cpu_vendor(struct cpuinfo_x86 *c)
>                if (!cpu_devs[i])
>                        break;
> 
> +               if (!cpu_devs[i]->c_ident[0])
> +                       continue;
> +
>                if (!strcmp(v, cpu_devs[i]->c_ident[0]) ||
>                    (cpu_devs[i]->c_ident[1] &&
>                     !strcmp(v, cpu_devs[i]->c_ident[1]))) {
> 
> 
> however, Peter's requirement to remove c_ident renders my patch 
> somewhat less useful back on RDC.  /proc/cpuinfo then lists the 
> vendor as 'RDC' (an improvement over not applying the patch) and 
> the model name as '486' (also an improvement), but for some 
> reason the variants in my case statement then no longer make it 
> through to /proc/info.  I don't think this is a big deal, and I
> still think the patch is worth applying with this change.
> 

Well, as I said, the generic code probably needs to change somewhat to
print that stuff.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/