linux-kernel - Re: [PATCH] MIPS: remove RELOC_HIDE on __pa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C5F8ED8.90301@gmail.com>
Date:	Sun, 08 Aug 2010 22:15:04 -0700
From:	David Daney <david.s.daney@...il.com>
To:	Namhyung Kim <namhyung@...il.com>
CC:	Ralf Baechle <ralf@...ux-mips.org>, linux-kernel@...r.kernel.org,
	David Daney <ddaney@...iumnetworks.com>,
	linux-mips@...ux-mips.org
Subject: Re: [PATCH] MIPS: remove RELOC_HIDE on __pa_symbol

  On 08/08/2010 12:57 PM, Namhyung Kim wrote:
> remove unneccessary use of RELOC_HIDE(). It does simple addition of ptr and
> offset and in this case (offset 0) does practically nothing. It does NOT do
> anything with linker relocation.
>

Maybe you could explain in more detail the problems you are having with 
the current definition of __pa_symbol().  I would be hesitant to change 
this bit of black magic unless there is a concrete problem you are 
trying to solve.

David Daney


> Signed-off-by: Namhyung Kim<namhyung@...il.com>
> ---
>   arch/mips/include/asm/page.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/include/asm/page.h b/arch/mips/include/asm/page.h
> index a16beaf..f7e2684 100644
> --- a/arch/mips/include/asm/page.h
> +++ b/arch/mips/include/asm/page.h
> @@ -150,7 +150,7 @@ typedef struct { unsigned long pgprot; } pgprot_t;
>       ((unsigned long)(x) - PAGE_OFFSET + PHYS_OFFSET)
>   #endif
>   #define __va(x)		((void *)((unsigned long)(x) + PAGE_OFFSET - PHYS_OFFSET))
> -#define __pa_symbol(x)	__pa(RELOC_HIDE((unsigned long)(x), 0))
> +#define __pa_symbol(x)	__pa(x)
>
>   #define pfn_to_kaddr(pfn)	__va((pfn)<<  PAGE_SHIFT)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/