linux-kernel - Re: [PATCH 1/4] arch/frv: Removing dead RAMKERNEL config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100810093717.GD22436@nokia.com>
Date:	Tue, 10 Aug 2010 12:37:17 +0300
From:	Felipe Balbi <felipe.balbi@...ia.com>
To:	ext Christian Dietrich <qy03fugy@...d.informatik.uni-erlangen.de>
Cc:	David Howells <dhowells@...hat.com>, Tejun Heo <tj@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"vamos-dev@...informatik.uni-erlangen.de" 
	<vamos-dev@...informatik.uni-erlangen.de>
Subject: Re: [PATCH 1/4] arch/frv: Removing dead RAMKERNEL config option

Hi,

On Tue, Aug 10, 2010 at 11:11:08AM +0200, ext Christian Dietrich wrote:
>diff --git a/arch/frv/mm/init.c b/arch/frv/mm/init.c
>index ed64588..73586ad 100644
>--- a/arch/frv/mm/init.c
>+++ b/arch/frv/mm/init.c
>@@ -170,23 +170,6 @@ void __init mem_init(void)
>  */
> void free_initmem(void)
> {
>-#if defined(CONFIG_RAMKERNEL) && !defined(CONFIG_PROTECT_KERNEL)
>-	unsigned long start, end, addr;
>-
>-	start = PAGE_ALIGN((unsigned long) &__init_begin);	/* round up */
>-	end   = ((unsigned long) &__init_end) & PAGE_MASK;	/* round down */
>-
>-	/* next to check that the page we free is not a partial page */
>-	for (addr = start; addr < end; addr += PAGE_SIZE) {
>-		ClearPageReserved(virt_to_page(addr));
>-		init_page_count(virt_to_page(addr));
>-		free_page(addr);
>-		totalram_pages++;
>-	}
>-
>-	printk("Freeing unused kernel memory: %ldKiB freed (0x%lx - 0x%lx)\n",
>-	       (end - start) >> 10, start, end);
>-#endif
> } /* end free_initmem() */

and now you have an empty function... how about removing the function 
completely and it's uses ?

-- 
balbi

DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/